Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GBK charset description #8101 #7416

Merged
merged 6 commits into from
Jan 24, 2022
Merged

Add GBK charset description #8101 #7416

merged 6 commits into from
Jan 24, 2022

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jan 17, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new doc for the GBK character set and update some relevant sections.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qiancai qiancai requested a review from shichun-0415 January 17, 2022 06:10
@ti-chi-bot ti-chi-bot requested a review from TomShawn January 17, 2022 06:10
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2022
@qiancai qiancai changed the title Add GBK charset description #8101 [WIP]: Add GBK charset description #8101 Jan 17, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2022
@qiancai qiancai removed the request for review from TomShawn January 17, 2022 06:11
@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Jan 17, 2022
@qiancai qiancai changed the title [WIP]: Add GBK charset description #8101 Add GBK charset description #8101 Jan 18, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
shichun-0415
shichun-0415 reviewed Jan 19, 2022
View reviewed changes
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
character-set-and-collation.md Outdated Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
character-set-gbk.md Show resolved Hide resolved
character-set-gbk.md Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
dm/dm-overview.md Show resolved Hide resolved
tidb-lightning/tidb-lightning-overview.md Show resolved Hide resolved
shichun-0415
shichun-0415 reviewed Jan 19, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
@qiancai qiancai requested a review from zimulala January 20, 2022 13:54
zimulala
zimulala reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiancai
qiancai commented Jan 24, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 24, 2022
@qiancai
Copy link
Collaborator Author

qiancai commented Jan 24, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 24, 2022
@qiancai
Copy link
Collaborator Author

qiancai commented Jan 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ffd9bac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 24, 2022
@ti-chi-bot ti-chi-bot merged commit 5fcc87f into pingcap:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiancai @ti-chi-bot @zimulala @shichun-0415