tiflash: Add TiFlash compaction RPC and messages #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
proto/kvrpcpb.proto
Outdated
| message CompactErrorTooManyPendingTasks {} | ||
|
|
||
| message CompactRequest { | ||
| // If specified, the compaction will be performed starting from this start key. |
There was a problem hiding this comment.
Add comments about the behavior when the start_key is not set
There was a problem hiding this comment.
Thanks for the suggestion! More comments have been added to important fields.
JaySon-Huang
approved these changes
May 17, 2022
flowbehappy
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The TiFlash Compaction API looks very differently compared to TiKV's. So that we should move these things out when we are going through #912 .