-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add Notepad like repos to text-editor collection #1811
Conversation
CI error unrelated: https://github.com/pingcap/ossinsight/actions/runs/11514447324/job/32053086908?pr=1811#step:5:111 Text-editor collection looks good:
Failed at Hyperledger Foundation collection:
There is a rename: |
Try to fix the ci with commands: cd ./configs/collections
find . -name "*.yml" -exec sed -i '' 's/hyperledger\/bevel/hyperledger-bevel\/bevel/g' {} + or just modify the wrong collection config file manually. |
b2178a3
to
327ac75
Compare
Git action checkout wrong commit, 6095984 is the latest commit at main branch:
https://github.com/pingcap/ossinsight/actions/runs/11529099298/job/32097111926?pr=1811#step:2:67 ossinsight/.github/workflows/verify-collection-configs.yml Lines 3 to 4 in 6095984
So, ci just check if main branch looks good, not this pr.
|
You can right, let me fix it. |
I am trying to fix the ci. Please merge the main branch into your branch and try it again.
|
OK, now git is checking out pr commits correctly.
Maybe it would be more robust to make the check script support repo renaming. |
OK, I will merged this PR first and fix the CI problem later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@inkydragon Thank you for your contribution! |
What problem does this PR solve?
Add following repo:
Stars and last update time at 2024-10-25