drainer: Clear the cache instead of refreshing after DDL to avoid unn…

…ecessary queries (#865)
pingcap · Jan 7, 2020 · 86e7ffb · 86e7ffb
1 parent 0dd2e28
commit 86e7ffb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/loader/load.go b/pkg/loader/load.go
@@ -237,6 +237,10 @@ func (s *loaderImpl) Close() {
 
 var utilGetTableInfo = getTableInfo
 
+func (s *loaderImpl) invalidateTableInfo(schema string, table string) {
+	s.tableInfos.Delete(quoteSchema(schema, table))
+}
+
 func (s *loaderImpl) refreshTableInfo(schema string, table string) (info *tableInfo, err error) {
 	log.Info("refresh table info", zap.String("schema", schema), zap.String("table", table))
 
@@ -559,9 +563,7 @@ func newBatchManager(s *loaderImpl) *batchManager {
 		fDDLSuccessCallback: func(txn *Txn) {
 			s.markSuccess(txn)
 			if needRefreshTableInfo(txn.DDL.SQL) {
-				if _, err := s.refreshTableInfo(txn.DDL.Database, txn.DDL.Table); err != nil {
-					log.Error("refresh table info failed", zap.String("database", txn.DDL.Database), zap.String("table", txn.DDL.Table), zap.Error(err))
-				}
+				s.invalidateTableInfo(txn.DDL.Database, txn.DDL.Table)
 			}
 		},
 	}