Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "drainer: Log version info before other logs, fix #242" #645

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Revert "drainer: Log version info before other logs, fix #242" #645

merged 2 commits into from
Jun 26, 2019

Conversation

july2993
Copy link
Contributor

Reverts #638

it alway log the [2019/06/21 21:12:25.917 +08:00] [INFO] [version.go:50.....

➜  bin git:(master) ✗ ./drainer -V
[2019/06/21 21:12:25.917 +08:00] [INFO] [version.go:50] ["Welcome to Drainer"] ["Release Version"=v3.0.0-rc.2-18-ge77e090d] ["Git Commit Hash"=e77e090d6c7843e4226f91825bcfd5564b4f4837] ["Build TS"="2019-06-21 01:06:43"] ["Go Version"=go1.12.5] ["Go OS/Arch"=darwin/amd64]
Release Version: v3.0.0-rc.2-18-ge77e090d
Git Commit Hash: e77e090d6c7843e4226f91825bcfd5564b4f4837
Build TS: 2019-06-21 01:06:43
Go Version: go1.12.5
Go OS/Arch: darwin/amd64

➜  bin git:(master) ✗ ./drainer -h
[2019/06/21 21:12:28.587 +08:00] [INFO] [version.go:50] ["Welcome to Drainer"] ["Release Version"=v3.0.0-rc.2-18-ge77e090d] ["Git Commit Hash"=e77e090d6c7843e4226f91825bcfd5564b4f4837] ["Build TS"="2019-06-21 01:06:43"] ["Go Version"=go1.12.5] ["Go OS/Arch"=darwin/amd64]
Usage of drainer:
  -L string
    	log level: debug, info, warn, error, fatal (default "info")
  -V	print version information and exit

@kennytm
Copy link
Contributor

kennytm commented Jun 21, 2019

Should #242 be re-opened?

@july2993
Copy link
Contributor Author

Should #242 be re-opened?

it can be open if revert this

@july2993 july2993 requested a review from suzaku June 24, 2019 02:13
suzaku
suzaku reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 requested a review from kennytm June 24, 2019 10:02
csuzhangxc
csuzhangxc approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 1513f5d into master Jun 26, 2019
@july2993 july2993 deleted the revert-638-fix-242 branch June 26, 2019 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@july2993 @kennytm @suzaku @csuzhangxc