sync-diff-inspector: fix rows unclosed (#681)

ref #678
pingcap · Sep 29, 2022 · 422258e · 422258e
1 parent 4572996
commit 422258e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/dbutil/table.go b/pkg/dbutil/table.go
@@ -78,10 +78,13 @@ func addClusteredAnnotationForPrimaryKey(raw string, replace string) (string, er
 
 func isPKISHandle(ctx context.Context, db QueryExecutor, schemaName string, tableName string) bool {
 	query := fmt.Sprintf("SELECT _tidb_rowid FROM %s LIMIT 0;", TableName(schemaName, tableName))
-	_, err := db.QueryContext(ctx, query)
+	rows, err := db.QueryContext(ctx, query)
 	if err != nil && strings.Contains(err.Error(), "Unknown column") {
 		return true
 	}
+	if rows != nil {
+		rows.Close()
+	}
 	return false
 }