Skip to content

br: disable stats for log task#55261

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
Leavrth:disable_stats_for_log_task
Jan 20, 2025
Merged

br: disable stats for log task#55261
ti-chi-bot[bot] merged 1 commit intopingcap:release-6.5from
Leavrth:disable_stats_for_log_task

Conversation

@Leavrth
Copy link
Copy Markdown
Contributor

@Leavrth Leavrth commented Aug 7, 2024

What problem does this PR solve?

Issue Number: ref #52088

Problem Summary:
The log task will start a domain, which spends much time to load statistic.

What changed and how does it work?

disable loading stats for log task

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Aug 7, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@cc91206). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #55261   +/-   ##
================================================
  Coverage               ?   75.0039%           
================================================
  Files                  ?       1097           
  Lines                  ?     363625           
  Branches               ?          0           
================================================
  Hits                   ?     272733           
  Misses                 ?      74508           
  Partials               ?      16384           

Comment thread br/cmd/br/stream.go
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 17, 2025
@ti-chi-bot ti-chi-bot Bot added the lgtm label Jan 20, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 20, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-17 09:25:12.351636393 +0000 UTC m=+283383.806682539: ☑️ agreed by YuJuncen.
  • 2025-01-20 07:49:17.76707537 +0000 UTC m=+80685.097994773: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot Bot merged commit e9a1f7f into pingcap:release-6.5 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants