Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup/pitr_coll: use target client of S3 #59044

Merged
merged 1 commit into from
Jan 20, 2025
Merged

backup/pitr_coll: use target client of S3 #59044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions br/pkg/storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,8 @@ func (rs *S3Storage) CopyFrom(ctx context.Context, e ExternalStorage, spec CopyS
Key: aws.String(rs.options.Prefix + spec.To),
}

// NOTE: Maybe check whether the Go SDK will handle 200 OK errors.
// https://repost.aws/knowledge-center/s3-resolve-200-internalerror
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed because I have checked the document and it reads:

If you call this API operation directly, make sure to design your application to parse the content of the response and handle it appropriately. If you use AWS SDKs, SDKs handle this condition. The SDKs detect the embedded error and apply error handling per your configuration settings (including automatically retrying the request as appropriate). If the condition persists, the SDKs throw an exception (or, for the SDKs that don't use exceptions, they return an error).

_, err := s.svc.CopyObjectWithContext(ctx, copyInput)
// We must use the client of the target region.
_, err := rs.svc.CopyObjectWithContext(ctx, copyInput)
return err
}

Expand Down
Loading