Skip to content

Conversation

@bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Feb 27, 2025

What problem does this PR solve?

Issue Number: close #59886

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: 童剑 <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@tiprow
Copy link

tiprow bot commented Feb 27, 2025

Hi @bufferflies. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: 童剑 <[email protected]>
@bufferflies bufferflies marked this pull request as ready for review March 3, 2025 09:31
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked labels Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 73.6455%. Comparing base (67edd7d) to head (8f692c7).
Report is 55 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59820        +/-   ##
================================================
+ Coverage   72.9760%   73.6455%   +0.6695%     
================================================
  Files          1699       1703         +4     
  Lines        469387     477737      +8350     
================================================
+ Hits         342540     351832      +9292     
+ Misses       105739     104651      -1088     
- Partials      21108      21254       +146     
Flag Coverage Δ
integration 42.8929% <0.0000%> (?)
unit 72.5873% <27.7777%> (+0.4091%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.6521% <ø> (+1.6296%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bufferflies
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 4, 2025
Signed-off-by: 童剑 <[email protected]>
@bufferflies
Copy link
Contributor Author

/test check-dev2

@tiprow
Copy link

tiprow bot commented Mar 4, 2025

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 4, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-04 09:00:34.050539154 +0000 UTC m=+345747.179458902: ☑️ agreed by okJiang.
  • 2025-03-06 01:41:35.46605693 +0000 UTC m=+492208.594976671: ☑️ agreed by lcwangchao.

@bufferflies
Copy link
Contributor Author

/ping bb7133, qw4990, yudongusa

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also open a document PR.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lcwangchao, okJiang, qw4990, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 11, 2025
@bufferflies
Copy link
Contributor Author

Please also open a document PR.

link pingcap/docs-cn#19534

@bufferflies
Copy link
Contributor Author

/test unit-test

@tiprow
Copy link

tiprow bot commented Mar 11, 2025

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bufferflies
Copy link
Contributor Author

/test unit-test

@tiprow
Copy link

tiprow bot commented Mar 11, 2025

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 9d1dd4d into pingcap:master Mar 11, 2025
24 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: add new sql syntax to show the distribution of the regions

6 participants