-
Notifications
You must be signed in to change notification settings - Fork 6.1k
add index: mark ErrCompacted from etcd as retryable error #62794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be33fc3 to
c27d842
Compare
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #62794 +/- ##
================================================
+ Coverage 72.8947% 73.4896% +0.5949%
================================================
Files 1771 1787 +16
Lines 486289 497248 +10959
================================================
+ Hits 354479 365426 +10947
+ Misses 110165 109789 -376
- Partials 21645 22033 +388
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggest split this into 2, one for bug fix, and another for refactor, we might pick the bug fix back to old version, but the refactor part shouldn't in most cases
c27d842 to
df4ed13
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, fzzf678 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@CbcWestwolf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #59737
Problem Summary:
See the issue description.
What changed and how does it work?
Mark
ErrCompactedfrom etcd as retryable errorCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.