Skip to content

Conversation

@CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Aug 4, 2025

What problem does this PR solve?

Issue Number: close #59737

Problem Summary:

See the issue description.

What changed and how does it work?

Mark ErrCompacted from etcd as retryable error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2025
@CbcWestwolf CbcWestwolf force-pushed the fixissue59737 branch 2 times, most recently from be33fc3 to c27d842 Compare August 5, 2025 06:52
@CbcWestwolf CbcWestwolf changed the title DNM: * add index: mark ErrCompacted from etcd as retryable Aug 5, 2025
@CbcWestwolf
Copy link
Member Author

/retest

@CbcWestwolf CbcWestwolf changed the title add index: mark ErrCompacted from etcd as retryable add index: mark ErrCompacted from etcd as retryable error Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4896%. Comparing base (c43df07) to head (df4ed13).
⚠️ Report is 594 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62794        +/-   ##
================================================
+ Coverage   72.8947%   73.4896%   +0.5949%     
================================================
  Files          1771       1787        +16     
  Lines        486289     497248     +10959     
================================================
+ Hits         354479     365426     +10947     
+ Misses       110165     109789       -376     
- Partials      21645      22033       +388     
Flag Coverage Δ
integration 42.2635% <0.0000%> (?)
unit 72.2332% <100.0000%> (+0.0361%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2327% <ø> (-0.0798%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest split this into 2, one for bug fix, and another for refactor, we might pick the bug fix back to old version, but the refactor part shouldn't in most cases

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2025
@CbcWestwolf
Copy link
Member Author

I just split the original PR into two, another is #62833
PTAL for both @D3Hunter

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-05 08:55:43.287301979 +0000 UTC m=+344853.430063153: ☑️ agreed by D3Hunter.
  • 2025-08-05 09:13:08.264791429 +0000 UTC m=+345898.407552604: ☑️ agreed by fzzf678.

@CbcWestwolf
Copy link
Member Author

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 5, 2025

@CbcWestwolf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-mysql-client-test-next-gen be33fc3 link false /test pull-mysql-client-test-next-gen
non-block/pull-integration-e2e-test-next-gen be33fc3 link false /test pull-integration-e2e-test-next-gen
non-block/pull-mysql-test-next-gen be33fc3 link false /test pull-mysql-test-next-gen
non-block/pull-unit-test-next-gen df4ed13 link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit acbcbdf into pingcap:master Aug 5, 2025
25 of 26 checks passed
@CbcWestwolf CbcWestwolf deleted the fixissue59737 branch August 5, 2025 11:08
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #64755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add-index failed with etcdserver: mvcc: required revision has been compacted

4 participants