Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58986

What problem does this PR solve?

Issue Number: close #58985

Problem Summary: See #58985 (comment)

What changed and how does it work?

Move memory tracker consumption calling into each info schema table. On the other hand, I batch the records to avoid calling the memory tracker too frequently, which may affect the performance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> desc analyze select * from INFORMATION_SCHEMA.tables;
+----------------+----------+---------+------+---------------+----------------------------------------------------------+---------------+---------+------+
| id             | estRows  | actRows | task | access object | execution info                                           | operator info | memory  | disk |
+----------------+----------+---------+------+---------------+----------------------------------------------------------+---------------+---------+------+
| MemTableScan_4 | 10000.00 | 50823   | root | table:TABLES  | time:948.6ms, open:370ns, close:483ns, loops:51, RU:0.00 |               | 91.1 MB | N/A  |
+----------------+----------+---------+------+---------------+----------------------------------------------------------+---------------+---------+------+
1 row in set (0.95 sec)

mysql> set tidb_mem_quota_query = 80 << 20;
Query OK, 0 rows affected (0.00 sec)

mysql> desc analyze select * from INFORMATION_SCHEMA.tables;
ERROR 8175 (HY000): Your query has been cancelled due to exceeding the allowed memory limit for a single SQL query. Please try narrowing your query scope or increase the tidb_mem_quota_query limit and try again.[conn=3923771498]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 28, 2025
@ti-chi-bot
Copy link
Member Author

@tangenta This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sunrunaway for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 62ab083 link true /test build
idc-jenkins-ci-tidb/check_dev_2 62ab083 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 62ab083 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 62ab083 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 62ab083 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Benjamin2037 Benjamin2037 assigned wjhuang2016 and unassigned tangenta Dec 4, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants