Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #64356

What problem does this PR solve?

Issue Number: ref #60804

Problem Summary:

What changed and how does it work?

In #60804, we move auto id rebase from submitter to executor, to ensure the atomicity of create table.

In most cases, there are no problem with such changes. But BR sometimes restore db to lower version of TiDB cluster. For example, if BR with ver9.0 (or any version with #60804) backups db to TiDB with ver7.5 (or any version without #60804), rebase won't be executed by anyone.

To temporary solve this, this PR revert back part of the changes in #60804 to make restore happy again 😢.

Besides, there is a small problem with #55847. In this PR, we copy the old value of auto id to new table. Typically, it's ok with same version of TiDB. But in the following scenario, it also introduce a problem during rename table:

  • In TiDB v7.5.6, the job worker handles auto ID during rename table by copying the old value, deleting it, and then setting the new value.
  • While in v9.0, auto ID is rebased when applying the info schema diff. This means that when BR v9.0 applies the new diff, the old value has already been deleted, and it will overwrite the existing value with 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

BR has already used this PR to do test, and it works.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 28, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Member Author

@joechenrh This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 45bbb19 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 45bbb19 link true /test check-dev
pull-br-integration-test 45bbb19 link true /test pull-br-integration-test
idc-jenkins-ci-tidb/mysql-test 45bbb19 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 45bbb19 link true /test unit-test
pull-unit-test-ddlv1 45bbb19 link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/build 45bbb19 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants