-
Notifications
You must be signed in to change notification settings - Fork 6.1k
ddl: add auto ID rebase create table submitted by BR (#64356) #64762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
ddl: add auto ID rebase create table submitted by BR (#64356) #64762
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joechenrh This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #64356
What problem does this PR solve?
Issue Number: ref #60804
Problem Summary:
What changed and how does it work?
In #60804, we move auto id rebase from submitter to executor, to ensure the atomicity of create table.
In most cases, there are no problem with such changes. But BR sometimes restore db to lower version of TiDB cluster. For example, if BR with ver9.0 (or any version with #60804) backups db to TiDB with ver7.5 (or any version without #60804), rebase won't be executed by anyone.
To temporary solve this, this PR revert back part of the changes in #60804 to make restore happy again 😢.
Besides, there is a small problem with #55847. In this PR, we copy the old value of auto id to new table. Typically, it's ok with same version of TiDB. But in the following scenario, it also introduce a problem during rename table:
Check List
Tests
BR has already used this PR to do test, and it works.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.