fix anti semi join (#8792) (release-7.1) (#8793)

close #8791
pingcap · Feb 27, 2024 · 0dd1cc9 · 0dd1cc9
1 parent 1c08a30
commit 0dd1cc9
Show file tree

Hide file tree

Showing 2 changed files with 64 additions and 0 deletions.
diff --git a/dbms/src/Flash/tests/gtest_join_executor.cpp b/dbms/src/Flash/tests/gtest_join_executor.cpp
@@ -558,6 +558,68 @@ try
 }
 CATCH
 
+TEST_F(JoinExecutorTestRunner, Issue8791)
+try
+{
+    auto build_key = toNullableVec<Int64>(
+        "id",
+        {
+            2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
+            4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,
+            6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7,
+        });
+    auto build_col = toNullableVec<Int64>(
+        "build_value",
+        {
+            10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,
+            10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,
+            10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,
+            10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,
+        });
+    auto probe_key = toNullableVec<Int64>(
+        "id",
+        {
+            1, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,
+            4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 6,
+            6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 6, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 7,
+        });
+    auto probe_col = toNullableVec<Int64>(
+        "probe_value",
+        {
+            20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20,
+            20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20,
+            20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20,
+            20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20, 20,
+        });
+    context.addMockTable(
+        "issue_8791",
+        "build_table",
+        {{"id", TiDB::TP::TypeLongLong}, {"build_value", TiDB::TP::TypeLongLong}},
+        {build_key, build_col});
+    context.addMockTable(
+        "issue_8791",
+        "probe_table",
+        {{"id", TiDB::TP::TypeLongLong}, {"probe_value", TiDB::TP::TypeLongLong}},
+        {probe_key, probe_col});
+
+    auto request = context.scan("issue_8791", "probe_table")
+                       .join(
+                           context.scan("issue_8791", "build_table"),
+                           tipb::JoinType::TypeAntiSemiJoin,
+                           {col("id")},
+                           {},
+                           {},
+                           {gt(col("probe_value"), col("build_value"))},
+                           {})
+                       .aggregation({Count(col("id"))}, {})
+                       .build(context);
+
+    context.context->setSetting("max_block_size", Field(static_cast<UInt64>(200)));
+    auto expected_columns = {toVec<UInt64>({1})};
+    ASSERT_COLUMNS_EQ_UR(expected_columns, executeStreams(request, 1));
+}
+CATCH
+
 TEST_F(JoinExecutorTestRunner, JoinWithTableScan)
 try
 {

diff --git a/dbms/src/Interpreters/Join.cpp b/dbms/src/Interpreters/Join.cpp
@@ -876,6 +876,8 @@ Block Join::doJoinBlockHash(ProbeProcessInfo & probe_process_info) const
                     helper_col = helper_col->cut(probe_process_info.start_row, probe_process_info.end_row);
                 }
                 offsets_to_replicate->assign(offsets_to_replicate->begin() + probe_process_info.start_row, offsets_to_replicate->begin() + probe_process_info.end_row);
+                if (isAntiJoin(kind) && filter != nullptr)
+                    filter->assign(filter->begin() + probe_process_info.start_row, filter->begin() + probe_process_info.end_row);
             }
         }
     }