Skip to content

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jan 7, 2026

What problem does this PR solve?

Issue Number: close #10644

Problem Summary:

What is changed and how it works?

Include the missing header <memory>.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to support memory utilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

Resolves a build error in CPUAffinityManager.h by adding the <memory> header include. This enables the compiler to properly recognize std::shared_ptr<DB::Logger> used in the LoggerPtr member declaration.

Changes

Cohort / File(s) Change Summary
Memory Header Inclusion
dbms/src/Common/CPUAffinityManager.h
Added #include <memory> to resolve implicit instantiation error for std::shared_ptr template

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Suggested labels

size/XS, approved, lgtm

Suggested reviewers

  • xzhangxian1008
  • JinheLin
  • wshwsh12

Poem

🐰 A header was missing, the compiler did cry,
With shared_ptr undefined, the build couldn't fly,
One line of inclusion brought peace to the day—
Now memory utilities light up the way! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a missing header include to fix a build error.
Description check ✅ Passed The description follows the template structure with all required sections completed, including issue reference, commit message, checklist, and release note.
Linked Issues check ✅ Passed The PR successfully addresses the build error reported in issue #10644 by including the missing header in CPUAffinityManager.h.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to adding a single missing header include, directly addressing the build error in issue #10644 with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1360f3 and a9a3d67.

📒 Files selected for processing (1)
  • dbms/src/Common/CPUAffinityManager.h
🔇 Additional comments (1)
dbms/src/Common/CPUAffinityManager.h (1)

20-20: Critical fix: LGTM!

The addition of <memory> correctly resolves the AppleClang 17 build error. The std::shared_ptr<Logger> usage at line 37 requires this header per the C++ standard. The include placement among other standard library headers is appropriate.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 7, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-07 13:40:52.030288034 +0000 UTC m=+796007.848596466: ☑️ agreed by JaySon-Huang.
  • 2026-01-09 03:42:38.537223293 +0000 UTC m=+932914.355531715: ☑️ agreed by wshwsh12.

@JaySon-Huang
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 39411ec into pingcap:master Jan 9, 2026
8 checks passed
@zanmato1984 zanmato1984 deleted the fix/gh-10644 branch January 9, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error in CPUAffinityManager.h

4 participants