Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collation in position function #9601

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9377
Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support collation in `position` function

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @yibin87

@yibin87
Copy link
Contributor

yibin87 commented Nov 19, 2024

Generally, use ++variable instead of variable++ unless we do need to keep the unchanged value.

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

LibCASCIICaseSensitiveStringSearcher

Modern compiler should know if it needs to create a tmp object for variable++, so I think there is no difference between variable++ and ++variable.

dbms/src/TiDB/Collation/Collator.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 21, 2024
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 01:12:35.471204313 +0000 UTC m=+80543.090858829: ☑️ agreed by yibin87.
  • 2024-11-22 12:33:35.903126019 +0000 UTC m=+207803.522780546: ☑️ agreed by windtalker.

Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

@xzhangxian1008: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

@xzhangxian1008: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test 4c86a97 link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position function does not support collation
4 participants