*: Refine MutableSupport and DeltaMergeDefines #9746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/work-in-progress
JinheLin
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
JinheLin
force-pushed
the
refine_internal_cols
branch
from
cc536ad to
b88095a
Compare
JinheLin
force-pushed
the
refine_internal_cols
branch
from
e263f5a to
46242bc
Compare
|
/retest |
Lloyd-Pottiger
approved these changes
Dec 30, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
yibin87
pushed a commit
to yibin87/tiflash
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9673
Problem Summary:
After #9608, the storage format of strings depends on
STORAGE_FORMAT_CURRENT.But
MutableSupport::tidb_pk_column_string_typeis a static variable that is only initialized once at program startup. Its value depends on the initialization value ofSTORAGE_FORMAT_CURRENTin the code, and modifying the configuration will not change it.And in order to test different storage formats, some unit-tests will dynamically modify the configuration of storage formats.
In summary, we need to dynamically obtain the object of
DataTypeStringbased on the value ofSTORAGE_FORMAT_CURRENT.What is changed and how it works?
Dynamically obtain the object of
DataTypeStringbased on the value ofSTORAGE_FORMAT_CURRENTinMutableSupport.cpp-MutSup::getTiDBPkColumnStringType()DeltaMergeDefines.cpp-getExtraStringHandleColumnDefine()Also this PR refine code in
MutableSupport.*andDeltaMergeDefines.*.Check List
Tests
Side effects
Documentation
Release note