Fix chat timeline row height estimation#1093
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
What Changed
Improved chat timeline virtualization height estimation by switching from coarse message-only estimates to row-aware estimates for user messages, assistant messages, work groups, proposed plan cards, and the working indicator.
Assistant row estimates now also account for markdown structure and changed-files summaries, while proposed plans and work groups use estimators closer to their actual rendered shape.
Fixes: #1035
This PR supersedes #1054.
Why
Some chat rows were being underestimated, which could cause overlapping content and visible scroll instability in virtualized threads.
UI Changes
Same as Why ^
Checklist
Note
Fix chat timeline row height estimation using content-aware logic
estimateTimelineRowHeightin timelineHeight.ts, covering work, working, proposed-plan, and message rows.MessagesTimelineattachesassistantDiffSummarydirectly to eachmessagerow object, removing the per-render map lookup.Macroscope summarized bed6475.