(fix) set env-mode to loose for dev#1115
Open
MathiasGruber wants to merge 1 commit intopingdotgg:mainfrom
Open
(fix) set env-mode to loose for dev#1115MathiasGruber wants to merge 1 commit intopingdotgg:mainfrom
MathiasGruber wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added
--env-mode=looseto all dev-mode turbo invocations in scripts/dev-runner.tsWhy
Turbo v2 defaults to --env-mode=strict, which strips environment variables not listed in turbo.json's globalEnv before
passing them to child tasks. This meant for instance that my
AZURE_API_KEYwasn't listed, and never reached the server or codex app-server.I alternatively considered explicitly adding the env vars in question to
globalPassThroughEnvinturbo.json, but for maintainability I believe this is a better solution considering these are dev runnersUI Changes
None
Checklist
Note
Set
--env-mode=loosefor all dev runner modesAdds
--env-mode=looseto the CLI arguments fordev,dev:server,dev:web, anddev:desktopin dev-runner.ts. This relaxes environment variable resolution during local development.Macroscope summarized dd1fcf5.