fix(ui): keep prior tool calls visible in thread timeline#1118
Closed
zortos293 wants to merge 1 commit intopingdotgg:mainfrom
Closed
fix(ui): keep prior tool calls visible in thread timeline#1118zortos293 wants to merge 1 commit intopingdotgg:mainfrom
zortos293 wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Better implementation in #905 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
ChatView.logicso the thread timeline uses thread-wide activity visibility rather than filtering to only the latest turn.Why
Previously, the timeline only derived visible tool activity for the active turn, which caused completed tool calls from prior turns to disappear from the thread view. That made the history feel incomplete and made it harder to understand what work had already happened in the conversation.
This change fixes that by deriving the visible work log from the full thread activity list, which keeps the timeline accurate and predictable while preserving a small, focused fix.
UI Changes
Before:
After:

Checklist
Note
Keep prior tool calls visible in thread timeline by removing turn scoping
Previously,
workLogEntriesin ChatView.tsx was derived withderiveWorkLogEntries(threadActivities, activeLatestTurn?.turnId), which scoped entries to the active/latest turn and hid tool calls from earlier turns. A newderiveVisibleThreadWorkLogEntrieswrapper in ChatView.logic.ts callsderiveWorkLogEntrieswithout a turn ID, so all completed tool call activities across all turns are retained in the timeline.Macroscope summarized c6a514a.