Skip to content

fix(ui): keep prior tool calls visible in thread timeline#1118

Closed
zortos293 wants to merge 1 commit intopingdotgg:mainfrom
zortos293:fix/thread-toolcall-timeline-visibility
Closed

fix(ui): keep prior tool calls visible in thread timeline#1118
zortos293 wants to merge 1 commit intopingdotgg:mainfrom
zortos293:fix/thread-toolcall-timeline-visibility

Conversation

@zortos293
Copy link
Contributor

@zortos293 zortos293 commented Mar 15, 2026

What Changed

  • Fixed the chat thread timeline so completed tool-call activity from earlier turns stays visible instead of disappearing when a newer turn becomes active.
  • Moved the visible work-log derivation into ChatView.logic so the thread timeline uses thread-wide activity visibility rather than filtering to only the latest turn.
  • Added a regression test covering completed tool calls from multiple turns to prevent this from breaking again.

Why

Previously, the timeline only derived visible tool activity for the active turn, which caused completed tool calls from prior turns to disappear from the thread view. That made the history feel incomplete and made it harder to understand what work had already happened in the conversation.

This change fixes that by deriving the visible work log from the full thread activity list, which keeps the timeline accurate and predictable while preserving a small, focused fix.

UI Changes

Before:

image image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Keep prior tool calls visible in thread timeline by removing turn scoping

Previously, workLogEntries in ChatView.tsx was derived with deriveWorkLogEntries(threadActivities, activeLatestTurn?.turnId), which scoped entries to the active/latest turn and hid tool calls from earlier turns. A new deriveVisibleThreadWorkLogEntries wrapper in ChatView.logic.ts calls deriveWorkLogEntries without a turn ID, so all completed tool call activities across all turns are retained in the timeline.

Macroscope summarized c6a514a.

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4838c32e-5024-4a86-b155-70a1ae6526ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 15, 2026
@zortos293 zortos293 closed this Mar 15, 2026
@zortos293
Copy link
Contributor Author

zortos293 commented Mar 15, 2026

Better implementation in #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant