Skip to content

feat: add Launch Args setting for Claude provider #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 8 commits into from
Apr 15, 2026
Merged

feat: add Launch Args setting for Claude provider #1971

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a77e55
feat: add Enable Chrome setting for Claude provider
akarabach Apr 12, 2026
9873c01
feat: launch args instead of specific chrome flag
akarabach Apr 12, 2026
cfefd47
feat: use normal string with spaces
akarabach Apr 12, 2026
1730291
feat: fix parse args twice
akarabach Apr 12, 2026
5533364
feat: common parser of cli args, unit tests
akarabach Apr 13, 2026
459c130
feat: fixes cursor comment add boolean flags parameter
akarabach Apr 13, 2026
4931df9
Merge branch 'main' into feat/claude-chrome-integration
akarabach Apr 13, 2026
be6cca1
Merge origin/main into t3code/pr-1971/feat/claude-chrome-integration
juliusmarminge Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2680,6 +2680,7 @@ const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
),
);
const claudeBinaryPath = claudeSettings.binaryPath;
const enableChrome = claudeSettings.enableChrome;
const modelSelection =
input.modelSelection?.provider === "claudeAgent" ? input.modelSelection : undefined;
const caps = getClaudeModelCapabilities(modelSelection?.model);
Expand Down Expand Up @@ -2719,6 +2720,7 @@ const makeClaudeAdapter = Effect.fn("makeClaudeAdapter")(function* (
canUseTool,
env: process.env,
...(input.cwd ? { additionalDirectories: [input.cwd] } : {}),
...(enableChrome ? { extraArgs: { chrome: null } } : {}),
};

const queryRuntime = yield* Effect.try({
Expand Down
33 changes: 32 additions & 1 deletion apps/web/src/components/settings/SettingsPanels.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,8 @@ export function GeneralSettingsPanel() {
claudeAgent: Boolean(
settings.providers.claudeAgent.binaryPath !==
DEFAULT_UNIFIED_SETTINGS.providers.claudeAgent.binaryPath ||
settings.providers.claudeAgent.customModels.length > 0,
settings.providers.claudeAgent.customModels.length > 0 ||
settings.providers.claudeAgent.enableChrome,
),
});
const [customModelInputByProvider, setCustomModelInputByProvider] = useState<
Expand Down Expand Up @@ -1179,6 +1180,36 @@ export function GeneralSettingsPanel() {
</div>
) : null}

{providerCard.provider === "claudeAgent" ? (
<div className="border-t border-border/60 px-4 py-3 sm:px-5">
<div className="flex items-center justify-between">
<div>
<span className="text-xs font-medium text-foreground">
Enable Chrome
</span>
<span className="mt-0.5 block text-xs text-muted-foreground">
Launch Claude with Chrome browser integration (--chrome).
</span>
</div>
<Switch
checked={settings.providers.claudeAgent.enableChrome}
onCheckedChange={(checked) =>
updateSettings({
providers: {
...settings.providers,
claudeAgent: {
...settings.providers.claudeAgent,
enableChrome: Boolean(checked),
},
},
})
}
aria-label="Enable Chrome browser integration"
/>
</div>
</div>
) : null}

<div className="border-t border-border/60 px-4 py-3 sm:px-5">
<div className="text-xs font-medium text-foreground">Models</div>
<div className="mt-1 text-xs text-muted-foreground">
Expand Down
2 changes: 2 additions & 0 deletions packages/contracts/src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export const ClaudeSettings = Schema.Struct({
enabled: Schema.Boolean.pipe(Schema.withDecodingDefault(Effect.succeed(true))),
binaryPath: makeBinaryPathSetting("claude"),
customModels: Schema.Array(Schema.String).pipe(Schema.withDecodingDefault(Effect.succeed([]))),
enableChrome: Schema.Boolean.pipe(Schema.withDecodingDefault(Effect.succeed(false))),
});
export type ClaudeSettings = typeof ClaudeSettings.Type;

Expand Down Expand Up @@ -163,6 +164,7 @@ const ClaudeSettingsPatch = Schema.Struct({
enabled: Schema.optionalKey(Schema.Boolean),
binaryPath: Schema.optionalKey(Schema.String),
customModels: Schema.optionalKey(Schema.Array(Schema.String)),
enableChrome: Schema.optionalKey(Schema.Boolean),
});

export const ServerSettingsPatch = Schema.Struct({
Expand Down
Loading