Repository navigation
ci(mobile): build Android store releases on Blacksmith - #33565
Needs Human Approval
- Eligibility · Permissive mode · Your custom policy
- Correctness
Note
More information about how approvability works can be found in our Help Center.
Details
Eligibility
Android store builds move to Blacksmith, with optional local iOS builds and tag-based build records. The production Android profile also skips release lint tasks, requiring human review of the reduced release validation.
Additional Thinking
Your Custom Policy
The explicit prohibition on auto-approving added static-analysis suppressions applies: apps/mobile/eas.json adds -x lintVitalAnalyzeRelease -x lintVitalRelease. Human review is therefore required regardless of other safeguards. The separate product-default rule was considered; the changes primarily concern release infrastructure and build configuration, and that rule is not needed to determine the outcome.
Code
Moves Android production builds to local Blacksmith jobs, adds opt-in local iOS builds, separates build concurrency from OTA reconciliation, and records submitted builds using tags. Jobs use production credentials; Android submissions target Google Play's internal track. Safeguards include dependency installation before EAS commands, disabled persisted checkout credentials, submission-before-tag ordering, and ARM ABI validation. The production profile now builds ARM-only binaries and excludes two release lint tasks.
Review Context
Author juliusmarminge is an administrator and ping-devs member; no explicit ownership requirement was supplied. The supplied High finding concerns missing dependencies before EAS commands; author replies address it, and both current jobs visibly install dependencies first. Findings at Medium or higher are independently gated. Three other threads were reported resolved. Agent results are unknown, not passes; no CI prerequisite applies.
Verdict
The production Android build explicitly skips release lint analysis and enforcement, removing diagnostics from the store-build path. A human must decide whether accepting that reduced release validation is appropriate; the customer's explicit suppression requirement mandates this review.
Notes:
No code owners found in target merge base ad9e871
Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.