fix(web): add default thread env mode setting#892
Merged
juliusmarminge merged 5 commits intopingdotgg:mainfrom Mar 13, 2026
Merged
fix(web): add default thread env mode setting#892juliusmarminge merged 5 commits intopingdotgg:mainfrom
juliusmarminge merged 5 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
juliusmarminge
approved these changes
Mar 13, 2026
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 13, 2026
Upstream features: - Selective file staging in commit dialog (pingdotgg#872) - Compact Codex tool-call icons in chat timeline (pingdotgg#988) - Replace worktree toggle with Select dropdown (pingdotgg#1001) - Timestamp format override setting (pingdotgg#855) - Preferred editor resolver + useLocalStorage helper (pingdotgg#662) - Extract reusable clipboard hook and media queries (pingdotgg#1006) - Default thread env mode setting (pingdotgg#892) - Block image uploads during plan mode (pingdotgg#621) Upstream bug fixes: - Prompt editor + Plan mode cursor fixes (pingdotgg#867) - Composer @file autocomplete cursor/spacing bugs (pingdotgg#936) - Diff panel unclosable after retainSearchParams (pingdotgg#937) - Fix agent response duration always 1ms (pingdotgg#866) - Defer diff worker startup until diff opens (pingdotgg#934) - Fix new-thread shortcuts when terminal focused (pingdotgg#984) - PlanSidebar memory leak fix (pingdotgg#949) - WebSocket error logging (pingdotgg#948) - Desktop "Check for Updates" dialog (pingdotgg#955) - macOS logo alignment fix (pingdotgg#960) Upstream tooling: - Upgrade oxfmt/oxlint versions (pingdotgg#1010) - Update @vitejs/plugin-react to 6.0.0 (pingdotgg#1002) - Upgrade marketing app to Astro 6 (pingdotgg#1005) Conflict resolutions: - workspaceEntries.ts: kept our zortos-ported fuzzy search (better ranked insertion) over upstream's pingdotgg#256 - appSettings.ts: merged our display settings with upstream's timestamp format and env mode settings - MessagesTimeline.tsx: merged our showCommandOutput gating with upstream's compact tool-call icons - DiffPanel.tsx: fixed duplicate useAppSettings import - open.test.ts: added missing node:fs/os/path imports for new test
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New worktreeon each new threadWhy
New draft threads always defaulted to
local, even if a user consistently works inNew worktreemode. The existing toggle only changed the current draft thread, so users had to repeat the same interaction on every new thread.The right scope here is app-level persistence, not more draft-local state. That keeps existing thread behavior unchanged, preserves explicit overrides, and only affects brand-new draft thread creation.
Changes
defaultThreadEnvModeLocalandNew worktreeenvModeis already suppliedworktreemodeUI changes
Validation
bun run test src/appSettings.test.ts src/composerDraftStore.test.tsinapps/webbun fmtbun lintbun typecheckNote
Add configurable default thread environment mode setting to web app
defaultThreadEnvMode("local" | "worktree", default "local") to appSettings.ts, persisted viaAppSettingsSchema.chat.newLocalkeyboard shortcut in _chat.tsx to resolve env mode viaresolveSidebarNewThreadEnvMode, using the app default instead of a hardcoded value.chat.newLocalshortcut no longer hardcodes "local" mode — it now follows the user's configured default.Macroscope summarized 3ec278c.