Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11290] Add application logger pattern full-replacement support. #11293

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+522 −189
Open

[#11290] Add application logger pattern full-replacement support. #11293

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2beb53c
[#11290] full logger pattern replace, log4j
yjqg6666 Jul 26, 2024
b84ecf7
[#11290] full logger pattern replace, log4j2
yjqg6666 Jul 26, 2024
f3a6c49
[#11290] full logger pattern replace, logback
yjqg6666 Jul 26, 2024
329c67f
[#11290] log4j-it, extract testbase
yjqg6666 Jul 26, 2024
673c311
[#11290] log4j-it, add test for full-pattern replacement
yjqg6666 Jul 26, 2024
e5bbb27
[#11290] log4j2-it, extract PatternTestBase
yjqg6666 Jul 26, 2024
d57a5be
[#11290] log4j2-it, update TraceId check
yjqg6666 Jul 26, 2024
3d4f9d2
[#11290] log4j-it, update TraceId value check
yjqg6666 Jul 26, 2024
d1bcc6a
[#11290] log4j2-it, add test for full-pattern replacement
yjqg6666 Jul 26, 2024
456a2ad
[#11290] logback-it, update TraceId value check
yjqg6666 Jul 26, 2024
2e311a8
[#11290] logback-it, extract TestBase
yjqg6666 Jul 26, 2024
860feae
[#11290] logback-it, add test for full-pattern replacement
yjqg6666 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[#11290] logback-it, update TraceId value check
@yjqg6666
yjqg6666 committed Jul 26, 2024
commit 456a2ada5eae4668015597f7312b09c63c5ca7e8
5 changes: 4 additions & 1 deletion ...ugins-it/logback-it/src/test/java/com/navercorp/pinpoint/it/plugin/logback/LogbackIT.java
View file
Original file line number Diff line number Diff line change
@@ -48,7 +48,9 @@ public void test() {

checkVersion(logger);

Assertions.assertNotNull(MDC.get("PtxId"), "txId");
String ptxId = MDC.get("PtxId");
Assertions.assertNotNull(ptxId, "TxId");
Assertions.assertTrue(ptxId.contains("build.test.0^1"), "TxId value");
Assertions.assertNotNull(MDC.get("PspanId"), "spanId");
}

@@ -72,6 +74,7 @@ public void run() {
Assertions.assertNotNull(log, "log null");
Assertions.assertTrue(log.contains(msg), "contains msg");
Assertions.assertTrue(log.contains("TxId"), "contains TxId");
Assertions.assertTrue(log.contains("build.test.0^1"), "TxId value");

Assertions.assertNotNull(logger, "logger null");
checkVersion(logger);