Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge latest changes in main to analytics-models feature-dev branch #119

Open
wants to merge 28 commits into
base: feature-dev/analytics-models
Choose a base branch
from
Open

Merge latest changes in main to analytics-models feature-dev branch #119

wants to merge 28 commits into from

Commits on Feb 16, 2023

  1. Update str converter (#78)

    @thucngyyen
    thucngyyen committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    27f1041 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Fix conversion tag null config (#82) 

    * Update generated client to 0.1.7

* Fix null configs for converion_tag

* Linting

* Feature fix/conversion tag configs (#83)

* Linting

* Update test
    @thucngyyen
    thucngyyen committed Mar 6, 2023
    2 Configuration menu
    Copy the full SHA
    7d99b03 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Bug Fix logic for getting all pages in _list() method of BaseModel (#85) 

    Calling <entity>.get_all() would return a list of entities and a Bookmark model that returns a new entity_list on each Bookmark.get_next() call which performs API calls only when necessary to fetch a new set, and eventually returns all entities for the parent.
    @rushabhvaria
    rushabhvaria committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    17cd898 View commit details
    Browse the repository at this point in the history

  2. Bug Fix: Pass constructor client to PinterestBaseModel init (#87) 

    As a result of the `PinterestBaseModel.__init__` getting called without the passed in client from the `Ad` model constructor, the requests failed resulting in an Auth error. This PR should fix the problem.
    @rushabhvaria
    rushabhvaria committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    e93b9bb View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. pass the client to the bookmark get_next function (#89)

    @rushabhvaria
    rushabhvaria committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c8225a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Change model_fn for bookmark to list_fn instead of hardcodeing (#90)

    @rushabhvaria
    rushabhvaria committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b603f91 View commit details
    Browse the repository at this point in the history

  2. Revert "Change model_fn for bookmark to list_fn instead of hardcodeing ( 

    #90)" (#94)

This reverts commit b603f91.
    @rushabhvaria
    rushabhvaria committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    fb0afed View commit details
    Browse the repository at this point in the history

  3. Add cron workflow for integration test (#97)

    @rushabhvaria
    rushabhvaria committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5809820 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Add missing attributes to AdAccount model

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    c8ff3c9 View commit details
    Browse the repository at this point in the history

  2. Update spend cap for campaigns based on server side validation

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4cd5586 View commit details
    Browse the repository at this point in the history

  3. Update campaign model properties

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1f1e1f6 View commit details
    Browse the repository at this point in the history

  4. Update ad_group model properties and utils

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e675756 View commit details
    Browse the repository at this point in the history

  5. Update pin_creation in Pin model

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    70c159c View commit details
    Browse the repository at this point in the history

  6. update .gitignore to exclude dev logs

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    44d41a2 View commit details
    Browse the repository at this point in the history

  7. Update make file phony targets 

    As integration_tests was a folder too, a PHONY target needed to be added for the makefile target.
    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    71fd145 View commit details
    Browse the repository at this point in the history

  8. Change spend caps for campaign tests

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    3f5104b View commit details
    Browse the repository at this point in the history

  9. Change config for base model creating an ad_group

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ea209ae View commit details
    Browse the repository at this point in the history

  10. Fix model and tests: conversion tag, conversion event and pin (#96) 

    * Update conversion tag

* Update conversion event

* Update pin model
    @thucngyyen @rushabhvaria
    thucngyyen authored and rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0e26494 View commit details
    Browse the repository at this point in the history

  11. Test Boards Fixes (#100) 

    * fix: test board

* fix: test board

* fix: change media to base64

* fix: typo random  (#101)

* fix: typo

* Fix: typo
    @dfana01 @rushabhvaria
    dfana01 authored and rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    14ac406 View commit details
    Browse the repository at this point in the history

  12. change: check the assertion (#102)

    @dfana01 @rushabhvaria
    dfana01 authored and rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    f9fecd6 View commit details
    Browse the repository at this point in the history

  13. Clean organic data before running integ tests

    @rushabhvaria
    rushabhvaria committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    4a72e82 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Fix integration test set up (#104) 

    * Fix integration test set up

* Fix lint error
    @rushabhvaria
    rushabhvaria committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e28141d View commit details
    Browse the repository at this point in the history

  2. Fix bug for following bookmark on list_pins in Board model (#103) 

    * Fix bug for following bookmark on list_pins in Board model

* Don't pass params if cls present
    @rushabhvaria
    rushabhvaria committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    42b6ef6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Update version.py (#106)

    @rushabhvaria
    rushabhvaria committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5140ce5 View commit details
    Browse the repository at this point in the history

  2. Feature release/0.2.1 (#107) 

    * Generate docs 0.2.1

* Update doc versioning
    @thucngyyen
    thucngyyen committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    87c8581 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Fix ad group and conversion events integrationt tests (#113)

    @rushabhvaria
    rushabhvaria committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f48ced9 View commit details
    Browse the repository at this point in the history

  2. Pass client to base method from entity create classmethods (#112)

    @rushabhvaria
    rushabhvaria committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    929027c View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Fix to incorrect error message when wrong refresh token is passed in (#… 

    …123)

* fix to incorrect error message when wrong refresh token is passed in

* integration test
    @senseiseun
    senseiseun committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    813fc8d View commit details
    Browse the repository at this point in the history