pints issue 783 plot histogram #11
Conversation
|
Results are in submodule
|
|
The left plot shows all the available commit history, and right plot shows the last 12 commits, as histogram in Then the runs from the last commit are plotted in purple |
|
@MichaelClerx @martinjrobins See what you think and what else to add/change. Then I will do for the rest of the existing tests. |
|
Can you make the labels clearer? No idea what's going on now just from looking at those |
|
Also not 100% sure I like the lollipops. I know we said histogram, but do you think this would be nicer as three swarm plots (side by side)? |
|
Would also be good to see a histogram for all the data, so a plot done before any analysis. You're going a step too far here already :-) |
Left is all the data, or you mean even with the last commit as one histogram? I thought the idea here was to test the last commit, so we should look at the distribution without the last commit and compare our last commit's results against that distribution. And since we are testing the last commit, so we should never put that as part of the histogram (the old historical commits) -- correct me if I am wrong.
No analysis has been done yet... I just took out the last commit's results!
The lollipops are the results of the last commit which we wanted to test/check. Because the first few runs of that new commit, we won't have enough data to plot a histogram, so I decided to plot each data point out! So it is more like a delta mass, if you like, which gives the lollipops. And what three swarm plots? |
Updated the label a bit.
|
|
The first question is: what does the distribution of all test results look like. Once we have that, we can discuss how to compare old results to new in the group! |
The ones in the legend, I meant! |
I guess, to see the distribution of all test results look like, just ignore the lollipops plot, they should not change the overall distribution, so I guess that would do for discussion, no?
OK, sorry, didn't get you, I will change that. |
|
Is the legend any better now?
|
|
Maybe we don't need the hashes, and it could be something like "All 123 commits", "Last 10 commits", "Last commit" or something |
|
OK, how about this?
|
|
Better, thanks |
|
I still think it's hard to compare the lollipops with the histograms.
? |
|
Should I make another plot method for that? I still like this one (at least for now), and we could use either one later? |
|
What do you think @martinjrobins ? |
|
Thanks Chon. This is looking good. I'm happy representing the last commit with individual samples, since there isn't much data. The tails of the lollipops are a bit distracting though. Can we try cuttin the tails and just put dots down near the bottom/top of the plot? And probably make them a much different colour as well to make them stand out (red?) |
There was a problem hiding this comment.
Looking good, happy to merge once Martin's ideas are implemented:
Thanks Chon. This is looking good. I'm happy representing the last commit with individual samples, since there isn't much data. The tails of the lollipops are a bit distracting though. Can we try cuttin the tails and just put dots down near the bottom/top of the plot? And probably make them a much different colour as well to make them stand out (red?)
|
@chonlei maybe leave this for now, as Ben has been doing cool stuff in R that we might start using! |
Had a look at Ben's ones, I still think this slightly simpler histogram plot might be useful along with his plots! |
|
Me too, but I'm not sure how we're going to be making plots in the future. Might change to a system where all the plotting is done in R! |
Fix and close pints-team/pints#783.