slice stepout notebook #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben18785
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Thanks @FarmHJ -- looks great. Could we do the following:
- stop PINTS from printing to screen for those cases where it currently does (as this hinders readability of the notebook)
- remove the banana problem as this is a hard problem that I don't expect this method will do well on
- same for multimodal Gaussian
|
@FarmHJ after making requested changes you can let the reviewer know with this button |
MichaelClerx
approved these changes
Dec 12, 2023
|
Looks good to me. How do you feel about the correlated gaussian true vs estimated cdf @ben18785 ? |
|
Interesting. @FarmHJ -- can we try running the correlated Gaussian problem twice/a few times to see if it is a seed-specific thing? |
|
I tried running the correlated Gaussian problem twice. The true vs estimated cdf was worse the first time. The results in the current notebook is from the second run. |
|
@ben18785 ping ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15