Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes to twisted gaussian #806

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Cosmetic changes to twisted gaussian #806

merged 3 commits into from
Apr 25, 2019

Conversation

MichaelClerx
Copy link
Member

Also added value-based test (before I made the changes) to test they don't affect the result

See #784

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #806 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #806   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          52     52           
  Lines        5021   5021           
=====================================
  Hits         5021   5021
Impacted Files Coverage Δ
pints/toy/_twisted_gaussian_banana.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455511c...41586ad. Read the comment docs.

@fcooper8472
Copy link
Member

I don't understand how coverage has decreased..?

@MichaelClerx
Copy link
Member Author

Me neither. Codecov gets confused sometimes! Seems to have fixed itself now, back at 100%

Copy link
Member

@fcooper8472 fcooper8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@MichaelClerx MichaelClerx merged commit 816bed2 into master Apr 25, 2019
@MichaelClerx MichaelClerx deleted the twisted-gaussian branch April 25, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants