Skip to content

Commit

Permalink
Avoid allocation storing last active time
Browse files Browse the repository at this point in the history
  • Loading branch information
paulwe committed Apr 30, 2024
1 parent 51293a0 commit e1c2d85
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions candidate_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ type candidateBase struct {

resolvedAddr net.Addr

lastSent atomic.Value
lastReceived atomic.Value
lastSent atomic.Int64
lastReceived atomic.Int64
conn net.PacketConn

currAgent *Agent
Expand Down Expand Up @@ -400,27 +400,27 @@ func (c *candidateBase) String() string {
// LastReceived returns a time.Time indicating the last time
// this candidate was received
func (c *candidateBase) LastReceived() time.Time {
if lastReceived, ok := c.lastReceived.Load().(time.Time); ok {
return lastReceived
if lastReceived := c.lastReceived.Load(); lastReceived != 0 {
return time.Unix(0, lastReceived)
}
return time.Time{}
}

func (c *candidateBase) setLastReceived(t time.Time) {
c.lastReceived.Store(t)
c.lastReceived.Store(t.UnixNano())
}

// LastSent returns a time.Time indicating the last time
// this candidate was sent
func (c *candidateBase) LastSent() time.Time {
if lastSent, ok := c.lastSent.Load().(time.Time); ok {
return lastSent
if lastSent := c.lastSent.Load(); lastSent != 0 {
return time.Unix(0, lastSent)
}
return time.Time{}
}

func (c *candidateBase) setLastSent(t time.Time) {
c.lastSent.Store(t)
c.lastSent.Store(t.UnixNano())
}

func (c *candidateBase) seen(outbound bool) {
Expand Down
4 changes: 2 additions & 2 deletions candidate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,15 @@ func TestCandidateLastSent(t *testing.T) {
assert.Equal(t, candidate.LastSent(), time.Time{})
now := time.Now()
candidate.setLastSent(now)
assert.Equal(t, candidate.LastSent(), now)
assert.EqualValues(t, 0, now.Sub(candidate.LastSent()))
}

func TestCandidateLastReceived(t *testing.T) {
candidate := candidateBase{}
assert.Equal(t, candidate.LastReceived(), time.Time{})
now := time.Now()
candidate.setLastReceived(now)
assert.Equal(t, candidate.LastReceived(), now)
assert.EqualValues(t, 0, now.Sub(candidate.LastReceived()))
}

func TestCandidateFoundation(t *testing.T) {
Expand Down

0 comments on commit e1c2d85

Please sign in to comment.