Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize log messages #588

Closed
wants to merge 3 commits into from
Closed

Harmonize log messages #588

wants to merge 3 commits into from

Conversation

stv0g
Copy link
Member

@stv0g stv0g commented Jun 24, 2023

To be aligned with other logging messages

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 73.39% and project coverage change: -0.05 ⚠️

Comparison is base (db5d7ea) 78.50% compared to head (c8c2638) 78.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
- Coverage   78.50%   78.46%   -0.05%     
==========================================
  Files          42       42              
  Lines        4374     4403      +29     
==========================================
+ Hits         3434     3455      +21     
- Misses        726      732       +6     
- Partials      214      216       +2     
Flag Coverage Δ
go 78.46% <73.39%> (-0.05%) ⬇️
wasm 22.24% <0.91%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tcp_packet_conn.go 82.16% <0.00%> (ø)
udp_mux.go 82.14% <16.66%> (ø)
gather.go 67.06% <75.86%> (+0.27%) ⬆️
selection.go 83.02% <85.71%> (ø)
agent.go 82.46% <100.00%> (ø)
candidatepair.go 88.67% <100.00%> (ø)
tcp_mux.go 68.79% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stv0g stv0g force-pushed the trace-message-capitalization branch from a3435fe to 38d0e6d Compare June 24, 2023 08:06
@stv0g stv0g changed the title Fix capitalization of tracing messages Harmonize log messages Jun 24, 2023
@stv0g stv0g force-pushed the trace-message-capitalization branch from 7b940eb to 87ad4d9 Compare June 26, 2023 20:39
@stv0g stv0g force-pushed the trace-message-capitalization branch from 87ad4d9 to c8c2638 Compare June 26, 2023 20:41
@stv0g stv0g closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant