Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gather): change log level #593

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

ar-hosseinkhani
Copy link
Contributor

#587 I changed the log level to debug according to issue description. This is my first cooperation with an open source project and I should be merciful if this result in acceptance and merge.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -56.25 ⚠️

Comparison is base (52bac76) 78.57% compared to head (51e8bf4) 22.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #593       +/-   ##
===========================================
- Coverage   78.57%   22.32%   -56.25%     
===========================================
  Files          42       37        -5     
  Lines        4387     4277      -110     
===========================================
- Hits         3447      955     -2492     
- Misses        725     3282     +2557     
+ Partials      215       40      -175     
Flag Coverage Δ
go ?
wasm 22.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gather.go 0.00% <0.00%> (-66.79%) ⬇️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stv0g
Copy link
Member

stv0g commented Jul 3, 2023

Hi @ar-hosseinkhani,

thanks for your contribution. I've triggered the CI pipeline for your branch. Can you please force-push a fix for the commit message?

The test is currently failing as your commit message does not conform to our convention:

Error: Capitalize the subject line

Commit message
  fix(gather): add deleted imports

it failed 'Capitalize the subject line' of the following checks

* Separate subject from body with a blank line
* Limit the subject line to [5](https://github.com/pion/ice/actions/runs/5405125443/jobs/9895830433?pr=593#step:4:6)0 characters
* Capitalize the subject line
* Do not end the subject line with a period
* Wrap the body at [7](https://github.com/pion/ice/actions/runs/5405125443/jobs/9895830433?pr=593#step:4:9)2 characters

@stv0g stv0g force-pushed the gather/fix-change-log-level branch from 4a3b0e5 to 7ab8231 Compare July 6, 2023 05:59
@stv0g stv0g merged commit 4f32f10 into pion:master Jul 6, 2023
@stv0g stv0g mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants