Add GetRemoteCandidates()
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is analogue to GetLocalCandidates() and provides the user with the ability to get a slice of previously added remote candidates without keeping track of them in the application code.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 78.41% 78.50% +0.08%
==========================================
Files 42 42
Lines 4374 4387 +13
==========================================
+ Hits 3430 3444 +14
+ Misses 729 728 -1
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
at-wat
reviewed
Jul 3, 2023
|
Hi @at-wat, sure. I also added one for |
at-wat
reviewed
Jul 4, 2023
stv0g
force-pushed
the
get-remote-candidates
branch
from
d628db8
to
eddf3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is analogue to
GetLocalCandidates()and provides the user with the ability to get a slice of previously added remote candidates without keeping track of them in the application code.