Handle timer stop race in agent connectivity check #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulwe
force-pushed
the
connectivity-check-timer-race
branch
from
1072171
to
3fb852e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 79.11% 79.12%
=======================================
Files 41 41
Lines 3740 3741 +1
=======================================
+ Hits 2959 2960 +1
Misses 548 548
Partials 233 233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
paulwe
force-pushed
the
connectivity-check-timer-race
branch
from
3fb852e
to
622cc2b
Compare
paulwe
changed the title
paulwe
changed the title
paulwe
force-pushed
the
connectivity-check-timer-race
branch
from
622cc2b
to
64e7a77
Compare
boks1971
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
@davidzhao caught this in the last PR itself. I argued it was not an issue without reading up on the behaviour. My bad. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.