Escape spaces in IPv6 ZoneID with %20 #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
==========================================
+ Coverage 79.19% 79.20% +0.01%
==========================================
Files 41 41
Lines 3739 3741 +2
==========================================
+ Hits 2961 2963 +2
Misses 547 547
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sirzooro
force-pushed
the
fix_zoneid_with_spaces
branch
from
fefbc7f
to
a404ab6
Compare
Link-local IPv6 addresses may have ZoneID attached at the end. ZoneId is name of corresponding network interface. On Windows usually it is "Local connection". Space in ZoneID causes problem when ICE candidate is parsed so it has to be escaped. It looks that there is no escaping defined specifically for SDP; the closest one is RFC 6874 for URI. This fix partially uses this approach and replaces spaces with %20.
sirzooro
force-pushed
the
fix_zoneid_with_spaces
branch
from
a404ab6
to
92356b3
Compare
|
I have read more about this ZoneID and found that it has only local meaning and should not be sent out over the wire. So this PR is invalid, and different fix is needed here. I will create it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link-local IPv6 addresses may have ZoneID attached at the end. ZoneId is name of corresponding network interface. On Windows usually it is "Local connection". Space in ZoneID causes problem when ICE candidate is parsed so it has to be escaped. It looks that there is no escaping defined specifically for SDP; the closest one is RFC 6874 for URI. This fix partially uses this approach and replaces spaces with %20.
Description
Reference issue
Fixes #...