Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get selected candidate pair stats #735

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

boks1971
Copy link
Contributor

@boks1971 boks1971 commented Oct 3, 2024

It is useful to have stats from just the selected pair as a lightweight option where a lot of agents are running, for example, an SFU.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.24%. Comparing base (410d6ec) to head (486350b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
agent_stats.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   79.20%   79.24%   +0.03%     
==========================================
  Files          41       41              
  Lines        3799     3820      +21     
==========================================
+ Hits         3009     3027      +18     
- Misses        558      560       +2     
- Partials      232      233       +1     
Flag Coverage Δ
go 79.24% <85.71%> (+0.03%) ⬆️
wasm 22.23% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boks1971 boks1971 force-pushed the raja_selected_candidate_pair_stats branch from 7b1984f to 442ff5e Compare October 3, 2024 10:56
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

It is useful to have stats from just the selected pair as a lightweight
option where a lot of agents are running, for example, an SFU.

lint

Switch udp_mux_test to use sha256 instead of sha1 (#733)

Minor change to this test to stop using sha1 and remove the linter
exceptions.

Co-authored-by: Daniel Kessler <[email protected]>

Update module golang.org/x/net to v0.29.0

Generated by renovateBot

Update module github.com/pion/dtls/v3 to v3.0.3

Generated by renovateBot
@boks1971 boks1971 force-pushed the raja_selected_candidate_pair_stats branch from 442ff5e to d47bfa6 Compare October 7, 2024 07:03
@boks1971 boks1971 merged commit 854fdfd into master Oct 7, 2024
15 checks passed
@boks1971 boks1971 deleted the raja_selected_candidate_pair_stats branch October 7, 2024 07:08
boks1971 added a commit that referenced this pull request Oct 7, 2024
It is useful to have stats from just the selected pair as a lightweight
option where a lot of agents are running, for example, an SFU.

lint

Switch udp_mux_test to use sha256 instead of sha1 (#733)

Minor change to this test to stop using sha1 and remove the linter
exceptions.

Co-authored-by: Daniel Kessler <[email protected]>

Update module golang.org/x/net to v0.29.0

Generated by renovateBot

Update module github.com/pion/dtls/v3 to v3.0.3

Generated by renovateBot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants