Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce GC Pressure from Frequent ICE Gathering Events #737 #738

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: Reduce GC Pressure from Frequent ICE Gathering Events #737 #738

merged 1 commit into from
Oct 28, 2024

Conversation

arjunshajitech
Copy link
Contributor

Description

Reduce GC Pressure from Frequent ICE Gathering Events

Reference issue

Fixes #737

@Sean-Der
Copy link
Member

Nice find @arjunshajitech!

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (854fdfd) to head (75baa5c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
candidate_base.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   79.29%   78.60%   -0.70%     
==========================================
  Files          41       41              
  Lines        3820     4762     +942     
==========================================
+ Hits         3029     3743     +714     
- Misses        559      785     +226     
- Partials      232      234       +2
Flag Coverage Δ
go 78.60% <66.66%> (-0.70%) ⬇️
wasm 22.50% <0.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

@arjunshajitech I will get this merged now! I just need to rewrite the commit message.

I added you to the Pion org. Feel free to push branches directly to the repo (so your tests run right away)

I am very excited/thankful for your performance improvements. Not many people are up for this kind of work, so I want to empower you to keep doing it!

@Sean-Der Sean-Der closed this Oct 28, 2024
@Sean-Der Sean-Der reopened this Oct 28, 2024
@arjunshajitech @Sean-Der
Use sync.Pool for candidate inbound buffer
75baa5c 
This commit reduces garbage collection pressure by re-using the buffer
used for reading inbound ICE traffic.

Fixes pion#737
@Sean-Der Sean-Der merged commit 166b1b7 into pion:master Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce GC Pressure from Frequent ICE Gathering Events
2 participants
@arjunshajitech @Sean-Der