Migrate to pion/webrtc/v4 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 44.67% 44.67%
=======================================
Files 80 80
Lines 5498 5498
=======================================
Hits 2456 2456
Misses 2875 2875
Partials 167 167 ☔ View full report in Codecov by Sentry. |
at-wat
reviewed
Dec 9, 2024
There was a problem hiding this comment.
@3DRX thank you for your contribution!
I tried examples/webrtc on this branch and got:
Connection State has changed checking
x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2
x264 [info]: profile Constrained Baseline, level 3.0, 4:2:0, 8-bit
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x7c973a]
goroutine 36 [running]:
github.com/pion/mediadevices.(*baseTrack).rtcpReadLoop(0x799320?, {0x0, 0x0}, {0x7f096db2a068, 0xc0002be3f0}, 0xc0002b51f0)
/home/at-wat/go/src/github.com/pion/mediadevices/track.go:252 +0x7a
created by github.com/pion/mediadevices.(*baseTrack).bind in goroutine 1
/home/at-wat/go/src/github.com/pion/mediadevices/track.go:235 +0x858
exit status 2
Does it work on you environment?
|
@at-wat thanks for review! I believe this is fixed by pion/webrtc@2553783, I'll update pion/webrtc to v4.0.5. |
|
Yeah, this works for me. |
at-wat
reviewed
Dec 10, 2024
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to pion/webrtc/v4, code changes:
webrtc.RtpTransceiverInittowebrtc.RTPTransceiverInit.