Skip to content

Conversation

@ValorZard
Copy link
Contributor

Description

Second half of pion/webrtc#2898. See pion/webrtc#3097 for more details

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.68%. Comparing base (c395deb) to head (5d30179).

Files with missing lines Patch % Lines
jsep.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   65.84%   65.68%   -0.16%     
==========================================
  Files          12       12              
  Lines        1660     1664       +4     
==========================================
  Hits         1093     1093              
- Misses        467      471       +4     
  Partials      100      100              
Flag Coverage Δ
go 65.68% <0.00%> (-0.16%) ⬇️
wasm 65.50% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValorZard ValorZard marked this pull request as ready for review April 13, 2025 23:34
@ValorZard
Copy link
Contributor Author

Actually I just realized that this is probably all the changes needed here I think, since the rest has to be done in the webrtc repo

@JoeTurki
Copy link
Member

Yeah there is no extra logic to handle at the receiver, Can you reword your commit message? Error: Capitalize the subject line

Thank you :)

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoeTurki
Copy link
Member

@ValorZard Thank you so much, will you be able to squash your commits into a single commit and fix the commit messages, I can do it myself if no :)

Also check your email I invited you to the org so you're able to make branches, and run the CI directly :)

@JoeTurki
Copy link
Member

JoeTurki commented Apr 14, 2025

I was not able to push to your fork (permission denied) to fixup the commit, but i pushed your commit fb5eb14 congrats on your first commit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants