Skip to content

Conversation

JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Apr 15, 2025

Description

Remove ic2 from ice-options

Reference issue

I think the general idea is right here. But do NOT put ice2 into the ice-options here. Pion doesn't support ice2 yet. That is whole different big project.
For this issue and PR we should only add a=ice-options:trickle.

pion/webrtc#3097

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.29%. Comparing base (f0c4982) to head (2ed82a4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   71.33%   71.29%   -0.04%     
==========================================
  Files          12       12              
  Lines        1664     1662       -2     
==========================================
- Hits         1187     1185       -2     
  Misses        379      379              
  Partials       98       98              
Flag Coverage Δ
go 71.11% <100.00%> (-0.04%) ⬇️
wasm 71.29% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeTurki JoeTurki merged commit 2ed82a4 into master Apr 16, 2025
15 checks passed
@JoeTurki JoeTurki deleted the remove-ice2 branch April 16, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant