-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datachannel and sctp to include SetReadDeadline #2369
Conversation
@edaniels could you take a look at this too? |
@ckousik on it. just pushed on your branch to get true tagged versions so we can get your PR in |
Thank you! |
@ckousik I messed up on pion/datachannel@6d03d00. It breaks backwards compatibility by adding a new interface method. I'm going to extract it out into a new interface but in a future major release, it can be incorporated back in. |
Codecov ReportBase: 77.46% // Head: 70.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2369 +/- ##
==========================================
- Coverage 77.46% 70.15% -7.32%
==========================================
Files 87 64 -23
Lines 9275 3354 -5921
==========================================
- Hits 7185 2353 -4832
+ Misses 1655 873 -782
+ Partials 435 128 -307
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
230bf11
to
1c87561
Compare
1c87561
to
f274a25
Compare
Oof, you're bumping up against a regression in SCTP I believe. Let me see if I can work it out real quick. Otherwise, this will need to wait a bit |
Potentially blocked by pion/sctp#254 |
f274a25
to
907be87
Compare
Ended up reverting the failing commit in sctp to get a new version out (and put it back into master after). pion/sctp#255 tracks the issue. Will put this in and bump shortly. |
907be87
to
1047729
Compare
To include SetReadDeadline. A ReadDeadliner can now be used from an underlying DataChannel
1047729
to
10fdfce
Compare
Merged and bumped! I'm not sure how you plan on using the new method though? Will you use detach? |
Description
Datachannel and SCTP recently merged changes which allow setting read deadlines. This PR updates the datachannel and SCTP versions until tagged releases can be made for both repositories.
Reference issue
Fixes #...