Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestPeerConnection_Simulcast_RTX on v3 #2769

Merged
merged 1 commit into from
May 14, 2024

Conversation

aalekseevx
Copy link
Contributor

Newly added test could not pass as simulcast extension headers are not enabled by default on v3

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.54%. Comparing base (eb6e395) to head (e029893).
Report is 9 commits behind head on v3.

Files Patch % Lines
interceptor.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2769      +/-   ##
==========================================
+ Coverage   76.32%   78.54%   +2.21%     
==========================================
  Files          87       87              
  Lines        9846     8127    -1719     
==========================================
- Hits         7515     6383    -1132     
+ Misses       1866     1276     -590     
- Partials      465      468       +3     
Flag Coverage Δ
go 80.13% <33.33%> (+2.27%) ⬆️
wasm 65.09% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 1778f7f into pion:v3 May 14, 2024
9 of 12 checks passed
@Sean-Der
Copy link
Member

Thank you @aalekseevx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants