Fire OnTrack before reading first RTP #2790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2790 +/- ##
==========================================
+ Coverage 78.99% 79.06% +0.06%
==========================================
Files 87 87
Lines 8203 8171 -32
==========================================
- Hits 6480 6460 -20
+ Misses 1256 1246 -10
+ Partials 467 465 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edaniels
force-pushed
the
alwaysfireontrack
branch
from
61e945f
to
7a3880b
Compare
Prior to this, we would wait for a single RTP packet to figure out the codec which is not to spec.
edaniels
force-pushed
the
alwaysfireontrack
branch
from
7a3880b
to
169440e
Compare
edaniels
commented
Jun 20, 2024
| @@ -26,3 +26,4 @@ cover.out | |||
| examples/sfu-ws/cert.pem | |||
| examples/sfu-ws/key.pem | |||
| wasm_exec.js | |||
| *.DS_Store | |||
There was a problem hiding this comment.
Might as well never store these :)
edaniels
commented
Jun 20, 2024
| @@ -187,25 +167,6 @@ func (t *TrackRemote) ReadRTP() (*rtp.Packet, interceptor.Attributes, error) { | |||
| return r, attributes, nil | |||
| } | |||
|
|
|||
| // peek is like Read, but it doesn't discard the packet read | |||
| func (t *TrackRemote) peek(b []byte) (n int, a interceptor.Attributes, err error) { | |||
There was a problem hiding this comment.
This now becomes unused, is it okay to remove?
|
@Sean-Der it seems likely users would be relying on Codec and PayloadType being accessible when OnTrack is called. With this change, you'd need to read first before calling those. I could put the peek code into those two methods instead which would preserve the old behavior. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, we would wait for a single RTP packet to figure out the codec which is not to spec.
@Sean-Der, as far as I can tell based on what chrome does and what the spec says, we're suppose to fire off on track, even if the codec may not be set yet. What this means is you need to read at least one RTP packet on your own within OnTrack before getting that info. This may be a breaking change though.