Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bundler 2.0 restriction #51

Closed
wants to merge 1 commit into from

Conversation

spikeheap
Copy link

Allows Bundler >= 2.0 in addition to the existing set (' ~> 1.16') by removing the upper limit on Bundler version.

Describe the change

This PR resolves #50 by updating the Gemfile to allow Bundler >=2.0.

Why are we doing this?

We're doing this to allow TTY to be used with modern versions of Bundler.

Drawbacks

None that I could see.

Requirements

Put an X between brackets on each line if you have done the item:
[x] Tests written & passing locally? (Tested by creating project using local fork of gem)
[] Code style checked?
[] Rebased with master branch?
[] Documentaion updated?

Allows Bundler >= 2.0 in addition to the existing set (' ~> 1.16') by removing the upper limit on Bundler version.
@metalefty metalefty mentioned this pull request Apr 23, 2019
@mfechner
Copy link

Any chance to get that merged?

@piotrmurach
Copy link
Owner

@mfechner Thanks for asking. This is not as trivial as you may believe. Read more

@spikeheap
Copy link
Author

Closing as @piotrmurach is working on a better approach ❤️

@spikeheap spikeheap closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler 2 compatibility
3 participants