Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing libelf dependency to kernel-module-injector image #120

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Aug 19, 2022

this PR fixes problem of compiling DRBD module on Rocky Linux 9
more details: deckhouse/deckhouse#2268

Copy link
Member

@rck rck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this introduce a new Dockerfile? there is already an image for almalinux9 which should work. In general the build process depends a lot on the compiler version, how the distribution ships the kernel sources, and the version of the kernel (e.g., not all of them need libelf-dev) and that is the reason why we have different Dockerfiles for different distributions, I do not want to endorse some magic Dockerfile that is supposed to magically build for all distros/kernels/compilers.

So this needs more explanation, convincing, as is: NACK

@rck rck marked this pull request as draft August 22, 2022 05:34
@kvaps
Copy link
Member Author

kvaps commented Aug 22, 2022

Which is the Dockerfie used by piraeus-operator by default?
I would like to update just this, because having libelf-dev makes it working on Rocky Linux 9 as well.

@WanzenBug
Copy link
Member

I guess for Piraeus, which uses the Compile method by default, we really could have just a single image. I believe as long as the GCC version is modern enough to support all compile options on modern kernels we should be good.

But that's just speculation. KBuild will issue a warning if you use a different compiler when building the kmod compared to the kernel, and I assume that warning exists for a reason.

@kvaps
Copy link
Member Author

kvaps commented Aug 31, 2022

Can't we just put a few compilers into the image?
Or even better: try using gcc from the host namespace. User needs to install kernel-headers anyway, installing gcc shouldn't be a big deal though.

ref to the discussion about the warning https://patchwork.kernel.org/project/linux-kbuild/patch/[email protected]/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants