dockerfiles: switch to using docker buildx bake #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
docker-bake
branch
2 times, most recently
from
e429bce
to
12bea9c
Compare
|
Apparently still unstable :/ |
Using buildx bake, we can unify our build processes, no longer needing ad-hoc loops in makefiles. This also means docker will properly cache the different drbd9-* image stages, as we build for 9.1 and 9.2 versions in parallel, only diverging when we actually download the drbd package. Signed-off-by: Moritz Wanzenböck <[email protected]>
The latest release is backwards compatible again with 1.0.2. Signed-off-by: Moritz Wanzenböck <[email protected]>
Signed-off-by: Moritz Wanzenböck <[email protected]>
rck
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
guess it depends a bit what one considers more idiomatic: horrible Makefiles which I do know and love :) or some new "language" I don't know. but I see the benefit, good work.
I think e3c5ad6 needs more explanation in the commit message why splitting the cache was necessary/what breaks otherwise
By default, all images get cached to the same "scope" in github. This means that while we build the images concurrently, they all compete for the same cache location. This means that our cache only applies to (at most) one image, making it not that useful. To solve this, we have to provide separate "scopes" for all images. Signed-off-by: Moritz Wanzenböck <[email protected]>
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using buildx bake, we can unify our build processes, no longer needing ad-hoc loops in makefiles. This also means docker will properly cache the different drbd9-* image stages, as we build for 9.1 and 9.2 versions in parallel, only diverging when we actually download the drbd package.