-
Notifications
You must be signed in to change notification settings - Fork 467
Conversation
* Date: 9/1/15 | ||
* Time: 5:31 PM | ||
* developer STANIMIR MARINOV | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments.
You're missing |
The main problem.. its appears that openshift will not send emails. https://forums.openshift.com/php-53-of-openshift-they-support-the-mail-functions Its need to have in acra.php one hardcoded google acount (user/pass) and use googles SMTP to send emails.. I not like this solution |
I have tested report sending and it works. I have use mu mailgun key to send emails. I have publish my PHP part too d-a-n/acra-mailer#3 |
I think that this is ready for merge now. |
While it's important to you, it's not ready for generic usage. I'm sorry but this won't be merged as is. |
Ok :) |
@pires I have write TODO for the SHARED_SECRET. You can merge it now (debugging works) and to open new issue with this.. actually SHARED_SECRET is for the security but not for the obd-reader application this is for the security of the php mailer. But this can be done later. I`m too lazy to finish it now ;) |
@sytolk I understand laziness, I'm lazy too. But we need variables to be configurable. All of them have been detailed before. |
@pires you are right.. you are lazy too :) maybe I will do this but my working priorities are different now and I really want to see this PR #144 finished. good luck @Pho3niX90 👍 |
#135
Not tested yet.. and I`m not sure that openshift support php mail function :)