Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Add Acra #138

Closed
wants to merge 9 commits into from
Closed

Add Acra #138

wants to merge 9 commits into from

Conversation

sytolk
Copy link
Contributor

@sytolk sytolk commented Sep 1, 2015

#135
Not tested yet.. and I`m not sure that openshift support php mail function :)

* Date: 9/1/15
* Time: 5:31 PM
* developer STANIMIR MARINOV
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments.

@pires
Copy link
Owner

pires commented Sep 1, 2015

You're missing build.gradle as well.

@sytolk
Copy link
Contributor Author

sytolk commented Sep 2, 2015

The main problem.. its appears that openshift will not send emails. https://forums.openshift.com/php-53-of-openshift-they-support-the-mail-functions

Its need to have in acra.php one hardcoded google acount (user/pass) and use googles SMTP to send emails.. I not like this solution
I prefer to use mailgun SMTP
http://stackoverflow.com/questions/23064765/cant-send-email-through-openshift

@sytolk
Copy link
Contributor Author

sytolk commented Sep 4, 2015

I have tested report sending and it works. I have use mu mailgun key to send emails. I have publish my PHP part too d-a-n/acra-mailer#3

@sytolk
Copy link
Contributor Author

sytolk commented Sep 4, 2015

I think that this is ready for merge now.
TODO: SHARED_SECRET is hardcoded it can be received on saved in shared preferences email and with this will have email validation too. But it works and debugging with ACRA is more important for me now.

@pires
Copy link
Owner

pires commented Sep 4, 2015

While it's important to you, it's not ready for generic usage. I'm sorry but this won't be merged as is.

@pires pires added the feature label Sep 4, 2015
@pires pires self-assigned this Sep 4, 2015
@sytolk
Copy link
Contributor Author

sytolk commented Sep 4, 2015

Ok :)

@sytolk sytolk mentioned this pull request Sep 9, 2015
@sytolk
Copy link
Contributor Author

sytolk commented Sep 15, 2015

@pires I have write TODO for the SHARED_SECRET. You can merge it now (debugging works) and to open new issue with this.. actually SHARED_SECRET is for the security but not for the obd-reader application this is for the security of the php mailer. But this can be done later. I`m too lazy to finish it now ;)

@pires
Copy link
Owner

pires commented Sep 15, 2015

@sytolk I understand laziness, I'm lazy too. But we need variables to be configurable. All of them have been detailed before.
Also, the commit log is a mess. Please meld your commits into a single one after rebasing current changes in master.

@sytolk
Copy link
Contributor Author

sytolk commented Sep 15, 2015

@pires you are right.. you are lazy too :) maybe I will do this but my working priorities are different now and I really want to see this PR #144 finished. good luck @Pho3niX90 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants