Skip to content

Commit

Permalink
fix cilint failures
Browse files Browse the repository at this point in the history
these were introduced in a different PR
  • Loading branch information
crhntr committed Jul 7, 2023
1 parent 37b24af commit c33934e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions internal/builder/release_manifest_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ type ReleaseManifest struct {
StemcellVersion string `yaml:"-"`
}

type compiledPackage struct {
Stemcell string `yaml:"stemcell"`
}

type ReleaseManifestReader struct {
fs billy.Filesystem
}
Expand Down
6 changes: 3 additions & 3 deletions internal/builder/release_manifest_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"bytes"
"compress/gzip"
"crypto/sha1"
"fmt"
"encoding/hex"
"io"
"os"
"path/filepath"
Expand Down Expand Up @@ -59,7 +59,7 @@ func createReleaseTarball(releaseMetadata string) (*os.File, string) {
_, err = io.Copy(hash, file)
Expect(err).NotTo(HaveOccurred())

releaseSHA1 := fmt.Sprintf("%x", hash.Sum(nil))
releaseSHA1 := hex.EncodeToString(hash.Sum(nil))

err = file.Close()
Expect(err).NotTo(HaveOccurred())
Expand Down Expand Up @@ -220,7 +220,7 @@ version: 1.2.3
Expect(err).NotTo(HaveOccurred())

_, err = reader.Read(tarball.Name())
Expect(err).To(MatchError(fmt.Sprintf("failed to find release.MF in tarball")))
Expect(err).To(MatchError("failed to find release.MF in tarball"))
})
})

Expand Down

0 comments on commit c33934e

Please sign in to comment.