Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few internal refactors and added tests #418

Merged
merged 6 commits into from
Aug 1, 2023
Merged

a few internal refactors and added tests #418

merged 6 commits into from
Aug 1, 2023

Commits on Jul 20, 2023

  1. refactor: add test coverage to gh package

    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    889cf86 View commit details
    Browse the repository at this point in the history

  2. refactor: fix linter error S1017 in gh.RepositoryOwnerAndNameFromPath 

    Error: S1017: should replace this `if` statement with an unconditional `strings.TrimPrefix` (gosimple)
    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    81e0936 View commit details
    Browse the repository at this point in the history

  3. refactor: remove log line

    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1f99498 View commit details
    Browse the repository at this point in the history

  4. refactor: clean up vendor directory after test suite

    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    22eeb47 View commit details
    Browse the repository at this point in the history

  5. refactor(gh): remove useless defer

    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    53f0cca View commit details
    Browse the repository at this point in the history

  6. fix: misisng log package import

    @crhntr
    crhntr committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    719115f View commit details
    Browse the repository at this point in the history