-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated logic on when to bake Kilnfile arguments #485
Conversation
- Bake arguments from kilnfile only when the stub releases flag is not set. - This is causing TAS PRs checks to fail as currently for stub releases arguments are not needed. Authored-by: Ramkumar Vengadakrishnan <[email protected]>
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
we have a variable bootstrapping problem when we try to load variables before interpolating Kilnfiles Ram and I noticed the stemcell service does not do interpolation so we can also skip it for bake config this also adds a bit more testing for bake configs
Co-authored-by: Ramkumar Vengadakrishnan <[email protected]>
24b80c3
to
8211c78
Compare
- Also fixed --help argument for re-bake command Authored-by: Ramkumar Vengadakrishnan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs look good to me. I just ran an auto formatter to fix the import paths.
Installed version locally and it works now to generate a tile with |
Authored-by: Ramkumar Vengadakrishnan [email protected]