Collect and maintain branch coverage#1575
Merged
vihangm merged 2 commits intopixie-io:mainfrom Jun 26, 2023
Merged
Conversation
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
JamesMBartlett
approved these changes
Jun 26, 2023
Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: gcov doesn't collect branch coverage by default and lcov drops branch coverage from the files if it exists. This change ensures that we maintain and track branch coverage. Type of change: /kind cleanup Test Plan: Ran the coverage build and then the coverage cleanup script. Ensured that it now maintains branch coverage. --------- Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: gcov doesn't collect branch coverage by default and lcov drops branch coverage from the files if it exists. This change ensures that we maintain and track branch coverage. Type of change: /kind cleanup Test Plan: Ran the coverage build and then the coverage cleanup script. Ensured that it now maintains branch coverage. --------- Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: gcov doesn't collect branch coverage by default and lcov
drops branch coverage from the files if it exists.
This change ensures that we maintain and track branch coverage.
Type of change: /kind cleanup
Test Plan: Ran the coverage build and then the coverage cleanup
script. Ensured that it now maintains branch coverage.