Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value to Rich Text field #9526

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Nov 15, 2024

What does this PR do?

  • Adds Default Value to the Rich Text field
  • We had originally disabled it due to requirements for validation, but forgot to add it back in as acceptance criteria for the Image Upload feature

Discussion

  • As discussed with @Pashaminkovsky, follow-up work is to validate and properly throw errors if default value is not compatible with the Rich Text editor; we are leaving it up to the Mod Developer to make sure that they're passing html

Demo

Screenshot 2024-11-14 at 5 19 27 PM

https://www.loom.com/share/c9af0bf99ba54c9a8f815bb4fd7a7c11

Copy link

When the PR is merged, the first loom link found on this PR will be posted to #sprint-demo on Slack. Do not edit this comment manually.

@grahamlangford grahamlangford enabled auto-merge (squash) November 15, 2024 01:25
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (8318d74) to head (79d26ad).
Report is 512 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9526      +/-   ##
==========================================
+ Coverage   74.24%   75.77%   +1.52%     
==========================================
  Files        1332     1427      +95     
  Lines       40817    43057    +2240     
  Branches     7634     7923     +289     
==========================================
+ Hits        30306    32625    +2319     
+ Misses      10511    10432      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamlangford grahamlangford merged commit 82e1110 into main Nov 15, 2024
24 checks passed
@grahamlangford grahamlangford deleted the feature/add_default_value_to_rich_text_editor branch November 15, 2024 01:36
Copy link

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 55 seconds
commit  79d26ad
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/runtime/modVariables/variableSync.spec.ts › Mod Variable Sync › session variable cross-tab sync

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants